RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v14]

[Jim Laskey]

On Tue, 7 Nov 2023 15:51:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 899:
>> 
>>> 897:     /*
>>> 898:      * Return type so that launcher invokes the correct main
>>> 899:      */
>> 
>> If you are doing anymore edits then I think this method description could be improved to say that it returns the main method type.
>
> Another suggestion, if you are editing more, is the description on LoadMainClass (in java.c) is confusingly worded, he currently says "Loads a class and verifies that the main class is present". It invokes the helper's checkAndLoadMain so maybe the comment could be adjusted to say that it calls checkAndLoadMain to load the main class.

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1385191813