RFR: 8319196: ExecutableElement.getReceiverType doesn't return receiver types for methods loaded from bytecode [v5]

[Liam Miller-Cushon]

On Thu, 9 Nov 2023 17:29:04 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> looks good to me, just minor comments

I addressed the comments, thanks for the review!

I also updated the CSR [JDK-8319330](https://bugs.openjdk.org/browse/JDK-8319330) and moved it back to 'proposed'.

> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 84:
> 
>> 82: import static com.sun.tools.javac.jvm.ByteCodes.lushrl;
>> 83: import static com.sun.tools.javac.jvm.ByteCodes.lxor;
>> 84: import static com.sun.tools.javac.jvm.ByteCodes.ret;
> 
> this import doesn't seem to be used now

Done

> test/langtools/tools/javac/processing/model/element/TestExecutableReceiverType.java line 51:
> 
>> 49:             for (ExecutableElement e : ElementFilter.methodsIn(
>> 50:                   roundEnv.getElementsAnnotatedWith(ReceiverTypeKind.class))) {
>> 51:               count += testExecutable(e);
> 
> nit: indentation should be 4 spaces here, same issue below

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16482#issuecomment-1804326825
PR Review Comment: https://git.openjdk.org/jdk/pull/16482#discussion_r1388409119
PR Review Comment: https://git.openjdk.org/jdk/pull/16482#discussion_r1388409373