RFR: 8304446: javap --system flag doesn't override system APIs [v2]

[Adam Sotona]

On Fri, 10 Nov 2023 07:25:45 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Skip search over JDK modules for classes in unnamed package (mainly to skip JDK module-infos)
>
> src/jdk.jdeps/share/classes/com/sun/tools/javap/JavapTask.java line 28:
> 
>> 26: package com.sun.tools.javap;
>> 27: 
>> 28: import com.sun.tools.javac.file.Locations;
> 
> Nit: seems unused.

Removed, thanks.

> src/jdk.jdeps/share/classes/com/sun/tools/javap/JavapTask.java line 864:
> 
>> 862:                 fo = fileManager.getJavaFileForInput(moduleLocation, className, JavaFileObject.Kind.CLASS);
>> 863:             } else {
>> 864:                 if (className.indexOf('.') > 0) try {
> 
> I would put the try into a block - it is slightly longer, but much clear, I think.

Fixed, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16476#discussion_r1389076255
PR Review Comment: https://git.openjdk.org/jdk/pull/16476#discussion_r1389076418