RFR: JDK-8298405: Support Markdown in Documentation Comments [v4]

Jonathan Gibbons jjg at openjdk.org
Wed Nov 15 00:26:39 UTC 2023


On Wed, 8 Nov 2023 17:24:46 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 37:
> 
>> 35: 
>> 36: import java.nio.file.Path;
>> 37: import java.util.ArrayList;
> 
> Import in unused:
> Suggestion:

👍

> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 61:
> 
>> 59:     }
>> 60: 
>> 61:     ToolBox tb = new ToolBox();
> 
> Suggestion:
> 
>     private final ToolBox tb = new ToolBox();

Yeah, I tend to be lax about modifiers in test code. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1393475716
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1393475034


More information about the compiler-dev mailing list