RFR: JDK-8298405: Support Markdown in Documentation Comments [v4]

Jonathan Gibbons jjg at openjdk.org
Wed Nov 15 00:33:33 UTC 2023

On Wed, 8 Nov 2023 17:28:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 64:
>>> 62: 
>>> 63:     @Test
>>> 64:     public void testFindStandardTransformer_raw() throws Exception {
>> Checked exceptions are not thrown:
>> Suggestion:
>>     public void testFindStandardTransformer_raw() {
> I might be mistaken, but this and the testFindStandardTransformer_stream methods look like we are testing ServiceLoader API. I would leave just the stream version.

While these are weak tests, since they exercise different code patterns for access the standard transformer, such as may subsequently be included in any documentation.  I would prefer to leave both tests in place.

I have removed the unnecessary `throws` clauses.


PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1393480117

More information about the compiler-dev mailing list