RFR: 8320001: javac crashes while adding type annotations to constructor's return type [v2]

Vicente Romero vromero at openjdk.org
Wed Nov 22 00:42:47 UTC 2023


> Fix for [1] introduced a regression that is making some internal tests fail. Basically fix for [1] is trying to add annotations read from the class file to the corresponding symbol. Constructors are a bit special given that its return type is `void` thus type annotations can't be added to them. This fix is proposing just dropping the type annotation if it applies to the return type of a constructor.
> 
> TIA
> [1] https://bugs.openjdk.org/browse/JDK-8225377

Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:

  addressing review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16774/files
  - new: https://git.openjdk.org/jdk/pull/16774/files/ed0e312d..483f7287

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16774&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16774&range=00-01

  Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16774.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16774/head:pull/16774

PR: https://git.openjdk.org/jdk/pull/16774


More information about the compiler-dev mailing list