RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v32]
Pavel Rappo
prappo at openjdk.org
Thu Nov 23 10:48:23 UTC 2023
On Wed, 22 Nov 2023 15:29:08 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>
> Handle javadoc on top level elements properly
I've checked your recent commit [222e334](https://github.com/openjdk/jdk/pull/16461/commits/222e3346ac61a9116014791fac0ad60ef3950949) and can confirm that it fixes the issue with comments; thanks.
Feel free to add a tests for it. Regardless of whether the compiler has such a test, javadoc will have its own test. So it will be covered. But javadoc test will be indirect.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16461#issuecomment-1824193504
More information about the compiler-dev
mailing list