RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v34]

Alan Bateman alanb at openjdk.org
Fri Nov 24 11:32:23 UTC 2023

On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Address changes from JEP 445 to JEP 463.
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>> - Don't mark class on read.
>> - Remove reflection and annotation processing related to unnamed classes.
>> - Simplify main method search.
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>   Remove Test

src/java.base/share/classes/jdk/internal/misc/MethodFinder.java line 40:

> 38:     }
> 39: 
> 40:     private static final JavaLangAccess JLA = SharedSecrets.getJavaLangAccess();

The new shared secret and usage looks fine. It would be good to add a short class description and method description and make it clear it's for launcher usage, we don't want this used for anything else. Personally I would move JLA to to the top rather than after the constructor.


PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1404252179

More information about the compiler-dev mailing list