RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

Joe Darcy darcy at openjdk.org
Mon Nov 27 23:39:25 UTC 2023

On Thu, 2 Nov 2023 17:42:48 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> `UNNAMED_CLASSES` should probably be removed, as I think it is fully replaced with `IMPLICIT_CLASSES`, and I don't think there are bootstrap problems here (unlike in `jdk.internal.java.PreviewFeature`). I would say it would make sense to set the version to `JDK22`, although the difference is very small given the feature is a preview and requires `-source 22` anyway. (Although we keep the `@since` value for the duration of preview.)
> Changing

I had the same question when reading over the changes if JDK21 or JDK22 should be used for IMPLICIT_CLASSES.

I think it would help if the comment of the Feature enum documented what the expected protocol was for previewing features.


PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1406896429

More information about the compiler-dev mailing list