RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

[Joe Darcy]

On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Address changes from JEP 445 to JEP 463.
>> 
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>> 
>> - Don't mark class on read.
>> 
>> - Remove reflection and annotation processing related to unnamed classes.
>> 
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Requested changes

test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:

> 33: import java.lang.reflect.Modifier;
> 34: 
> 35: public class TestImplicitClass {

The test looks to be testing core reflection behavior (i.e. runtime behavior) and not compile-time behavior via javax.lang.model.

Core reflection tests should be done too, but done the core libraries tests, not langtools tests.

I might have overlooked it, but if some other exercise of compile-time modeling is not being done, please restore and update accordingly the sort of tests previously done in the now-deleted

test/langtools/tools/javac/processing/model/element/TestUnnamedClass.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1406905612