RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

Alan Bateman alanb at openjdk.org
Tue Nov 28 14:18:36 UTC 2023


On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Address changes from JEP 445 to JEP 463.
>> 
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>> 
>> - Don't mark class on read.
>> 
>> - Remove reflection and annotation processing related to unnamed classes.
>> 
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8315458
>  - Requested changes
>  - Remove Test
>  - Move findMainMethod to non-public access
>  - Handle javadoc on top level elements properly
>  - Update Class.java
>  - Update test
>  - Update findMainMethod as requested
>  - Add nested class test
>  - Move Implicitly Declared Classes to single directory
>  - ... and 30 more: https://git.openjdk.org/jdk/compare/2fae07f5...daacc0ba

src/java.base/share/classes/java/lang/Class.java line 2896:

> 2894:      * @param parameterTypes the parameter array
> 2895:      * @return the list of {@code Method} objects for the public methods of
> 2896:      *         this class matching the specified name and parameters

The return description seems to be copied from getDeclaredPublicMethods, I think you can drop it as the method description is clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1407832086


More information about the compiler-dev mailing list