RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

[Jim Laskey]

On Tue, 28 Nov 2023 14:43:36 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into 8315458
>>  - Requested changes
>>  - Remove Test
>>  - Move findMainMethod to non-public access
>>  - Handle javadoc on top level elements properly
>>  - Update Class.java
>>  - Update test
>>  - Update findMainMethod as requested
>>  - Add nested class test
>>  - Move Implicitly Declared Classes to single directory
>>  - ... and 30 more: https://git.openjdk.org/jdk/compare/2fae07f5...daacc0ba
>
> test/jdk/tools/launcher/modules/basic/LauncherErrors.java line 97:
> 
>> 95:                     .shouldContain("Error: Unable to load main class " + MAIN_CLASS + " in module " + TEST_MODULE)
>> 96:                     .shouldContain("java.security.AccessControlException")
>> 97:                     .shouldNotHaveExitValue(0);
> 
> The updates to the launcher tests look okay but I'm wondering if the "Caused by:" is the output now? I get it that the "Unable to ..." message has changed but has the format of the cause changed too?
> 
> I assume you'll fix up the copyright date on Arrrrgs and LauncherErrors before integrating.

"Caused by:" has (always) been missing from the named module version of the error message. I'll add in and modify the test accordingly. Updated copyright.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1408356364