RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

[Jim Laskey]

On Tue, 28 Nov 2023 15:51:37 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into 8315458
>>  - Requested changes
>>  - Remove Test
>>  - Move findMainMethod to non-public access
>>  - Handle javadoc on top level elements properly
>>  - Update Class.java
>>  - Update test
>>  - Update findMainMethod as requested
>>  - Add nested class test
>>  - Move Implicitly Declared Classes to single directory
>>  - ... and 30 more: https://git.openjdk.org/jdk/compare/2fae07f5...daacc0ba
>
> src/java.base/share/native/libjli/java.c line 415:
> 
>> 413:     CHECK_EXCEPTION_FAIL();
>> 414:     (*env)->CallStaticVoidMethod(env, mainClass, mainID, mainArgs);
>> 415:     return 1;
> 
> I think we should add a comment to each of the 4 invokeXXXX functions to say that they return 1 if the main method completes successfully or it throws. Just trying to head off someone asking why there isn't a CHECK_XXX after the CallStaticVoidMethod/CallVoidMethod.

Comments added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1408365265