RFR: 8320145: Compiler should accept final variable in Record Pattern

Jan Lahoda jlahoda at openjdk.org
Thu Nov 30 17:33:06 UTC 2023


On Thu, 30 Nov 2023 11:03:09 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

> With this PR, if the `final` keyword is detected, `analyzePattern` returns `PatternResult.PATTERN` and `parseCaseLabel` goes through the correct if-branch in line 3268.
> 
> This improves the error message in the case of record patterns for https://github.com/openjdk/jdk/pull/15997 as well.

Looks OK to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16899#pullrequestreview-1758062151


More information about the compiler-dev mailing list