RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

Aggelos Biboudis abimpoudis at openjdk.org
Wed Oct 4 10:02:44 UTC 2023


On Tue, 3 Oct 2023 09:13:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into primitive-patterns
>>  - Implement type pairs to exactnessMethod name
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Raffaello Giulietti <raffaello.giulietti at oracle.com>
>>  - 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview)
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java line 494:
> 
>> 492:                                                                     syms.classType.tsym)));
>> 493: 
>> 494:             // The boolean flag `hasUnconditionalPattern` is true when either there
> 
> A it surprised that something has changed here - can you expand?

Indeed that was not needed anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1345531726


More information about the compiler-dev mailing list