RFR: 8313613: Use JUnit in langtools/lib tests [v2]

Christian Stein cstein at openjdk.org
Tue Oct 10 13:32:43 UTC 2023


On Tue, 10 Oct 2023 05:18:34 GMT, Qing Xiao <xqoasis at openjdk.org> wrote:

>> Use JUnit Jupiter API in langtools/lib tests instead of TestNG. They are under test/langtools/lib/combo/tools/javac/combo/.
>> Modified tests that extend tools in CompilationTestCase and JavacTemplateTestBase to implement TestWatcher.
>
> Qing Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused JavacTemplateDiagnosticsPrinter.java

Hi! Here is a patch that cleans up the conversion by using the JUnit extension in a more canonical way: https://gist.github.com/sormuras/834e2f05b7d8784d70ad63e91b5e2d96

If the patch doesn't apply cleanly, I'll create a PR against your fork and branch - or you grant me write access to your `JUnit_javac_combo` branch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15281#issuecomment-1755433244


More information about the compiler-dev mailing list