RFR: 8317336: Assertion error thrown during 'this' escape analysis [v5]

Archie Cobbs acobbs at openjdk.org
Wed Oct 11 00:51:49 UTC 2023


> The 'this' escape analyzer was assuming that lambas could always be treated like blocks, in the sense that we can assume a block can never end in a plain expression. This assumption is not true for lambda's of the form `() -> foo` which do exactly that. In the case that `foo` was `this`, an assertion failure would ensue.
> 
> This patch explicitly clears any leftover `ExprRef`'s after evaluating a lambda body; this restores the asserted invariant when the lambda body is an expression.
> 
> This also fixes another variant of the same bug caused by certain enhanced `for()` loops. In this case, the leftover `ExprRef` was from evaluating the loop expression. This was just a side-effect of the analyzer failing to override `TreeScanner` to actually assign the loop expression to the loop variable.

Archie Cobbs has updated the pull request incrementally with three additional commits since the last revision:

 - Fix regression test class names.
 - Refactor patch to minimize it to just the required bugfix.
 - Fix inadvertent variable renaming.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16001/files
  - new: https://git.openjdk.org/jdk/pull/16001/files/09e42837..043e8fec

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16001&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16001&range=03-04

  Stats: 15 lines in 2 files changed: 1 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/16001.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16001/head:pull/16001

PR: https://git.openjdk.org/jdk/pull/16001


More information about the compiler-dev mailing list