RFR: 8317818: Combinatorial explosion during 'this' escape analysis

Vicente Romero vromero at openjdk.org
Wed Oct 11 17:40:50 UTC 2023


On Tue, 10 Oct 2023 16:55:22 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> The `this-escape` analysis stops infinite recursions during the analysis by keeping track of what methods have already been invoked with any given set of current references.
> 
> However, it was using the method call site, not the target method itself, for this tracking. This can lead to a combinatorial explosion, for example, if there are multiple recursive calls inside the target method, where we would end up recursing through all possible combinations of call sites before stopping the recursion.
> 
> The fix is to key on the target method itself, not on whatever call site.

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16125#pullrequestreview-1672044756


More information about the compiler-dev mailing list