RFR: 8313613: Use JUnit in langtools/lib tests [v5]

Christian Stein cstein at openjdk.org
Fri Oct 13 17:05:11 UTC 2023


On Fri, 13 Oct 2023 03:05:38 GMT, Qing Xiao <xqoasis at openjdk.org> wrote:

>> Use JUnit Jupiter API in langtools/lib tests instead of TestNG. They are under test/langtools/lib/combo/tools/javac/combo/.
>> Modified tests that extend tools in CompilationTestCase and JavacTemplateTestBase to implement TestWatcher.
>
> Qing Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Try to solve whitespace error

test/langtools/tools/javac/records/RecordCompilationTests.java line 1320:

> 1318:     void testCheckInitializationOrderInCompactConstructor() throws Exception {
> 1319:         int putField1 = -1;
> 1320:         int putField2 = -1;

Suggestion:

        FieldInstruction putField1 = null;
        FieldInstruction putField2 = null;


Was the conversion from FieldInstruction to int intended or a by-product of merging?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15281#discussion_r1358515419


More information about the compiler-dev mailing list