RFR: 8306914: Implementation of JEP Launch Multi-File Source-Code Programs [v2]

[Christian Stein]

On Mon, 16 Oct 2023 13:09:37 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix support for adding user-supplied modules on the module-path
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/ProgramDescriptor.java line 104:
> 
>> 102:                   .filter(string -> !string.isEmpty())
>> 103:                   .map(string -> string.replace('/', '.'))
>> 104:                   .map(string -> string.replace('\\', '.'))
> 
> Nit: I'd be a bit careful with the `` -> `.` replacement. `` is a valid file name character on UNIX-like system. Better use `File.separatorChar` or `sourceRootPath.getFileSystem().getSeparator()`. Although the practical impact is probably very low.

Addressed this in https://github.com/openjdk/jdk/pull/13712/commits/093ab1cef7383323deb74bffa511b81109ca4dd6

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13712#discussion_r1362314991