Integrated: 8318027: Support alternative name to jdk.internal.vm.compiler
Doug Simon
dnsimon at openjdk.org
Mon Oct 23 13:18:52 UTC 2023
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
> The Graal code base has [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) its module to `jdk.compiler.graal` as part of preparations for Project Galahad. Due to the way Java modules work, this requires a JDK change. The core of the issue is that the [service](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L37) by which HotSpot requests a Graal compilation is defined in JVMCI. Since JVMCI is in the boot layer, the service can only be implemented by a provider in the boot layer and the package defining the service must be exported to the provider's defining module. This export currently targets [`jdk.internal.vm.compiler`](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L28) and so the binding fails for the new Graal module. To address this, this PR reflects the Graal module rena
ming, including adjusting the qualified export.
>
> Edit: The target of the rename is now `jdk.graal.compiler` - see https://github.com/openjdk/jdk/pull/16189#issuecomment-1773764186
This pull request has now been integrated.
Changeset: bd22d238
Author: Doug Simon <dnsimon at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/bd22d2381fa3f21b113d5b8ef95fe15cec50b066
Stats: 40 lines in 10 files changed: 0 ins; 14 del; 26 mod
8318027: Support alternative name to jdk.internal.vm.compiler
Reviewed-by: erikj, ihse, kvn, alanb, mli
-------------
PR: https://git.openjdk.org/jdk/pull/16189
More information about the compiler-dev
mailing list