RFR: 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2]

[Liam Miller-Cushon]

On Mon, 30 Oct 2023 18:36:31 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates
>>   
>>   * handle annotating the same type twice (with runtime-visible and
>>     -invisible annotations)
>>   * don't throw an assertion on ill-formed type paths
>>   * null-check ClassSymbol typarams
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 2264:
> 
>> 2262:                 List<Attribute.TypeCompound> newList = deproxyTypeCompoundList(proxies);
>> 2263:                 sym.setTypeAttributes(newList.prependList(sym.getRawTypeAttributes()));
>> 2264:                 TypeAnnotationMapper.addTypeAnnotationsToSymbol(sym, newList);
> 
> I wonder if the new TypeAnnotationsMapper should actually live inside of ClassReader

I have tentatively gone ahead and moved it into ClassReader

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16407#discussion_r1376790553