RFR: 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2]

[Vicente Romero]

On Mon, 30 Oct 2023 20:55:04 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> Thanks for the review!
> 
> > I just wonder if it should be placed inside of ClassReader, if you want to keep it separated please consider not exposing its API as static methods.
> 
> Moving it into ClassReader is fine with me. I initially thought it might end up requiring more logic than it did. I left it in a separate class because it's still a medium amount of logic and is fairly self-contained, but if you're preference is to move it into ClassReader I'm happy to proceed with that.
> 
> Just for my understanding, if it was a separate class would the preferred style be to register it in `Context` and have `ClassReader` create an instance of it?

if it was a separate instance I would prefer ClassReader to create an instance of it even it it is not registered in Context, but registering it in Context would be the "standard" approach I think

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16407#issuecomment-1786097433