RFR: 8288660: JavaDoc should be more helpful if it doesn't recognize a tag [v2]

Jonathan Gibbons jjg at openjdk.org
Tue Sep 5 18:16:44 UTC 2023


On Fri, 1 Sep 2023 09:23:11 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java line 380:
>> 
>>> 378: 
>>> 379:     public static List<String> suggestSimilar(Collection<String> knownTags, String unknownTag) {
>>> 380:         final double MIN_SIMILARITY = 2.0 / 3;
>> 
>> Is there significance in `2.0 / 3` as compared to `0.667` etc
>
> No. I can change it if you want me to.

no biggie, except that the code makes you wonder at the implied specific precision here, as compared to a "simple" floating point number like `0.5` or even `0.75`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15494#discussion_r1316232957


More information about the compiler-dev mailing list