RFR: JDK-8312418: Add Elements.getEnumConstantBody [v4]

Jan Lahoda jlahoda at openjdk.org
Wed Sep 6 12:10:42 UTC 2023


On Thu, 24 Aug 2023 18:03:53 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reorder javadoc tags.
>
> test/langtools/tools/javac/processing/model/util/elements/TestGetEnumConstantBody.java line 64:
> 
>> 62: 
>> 63:             for (TypeElement typeElt : ElementFilter.typesIn(typeRoot.getEnclosedElements()) ) {
>> 64:                 System.out.println("Testing type " + typeElt);
> 
> should the `println` invocations be removed?

This may be a matter of style, but logs like this inside tests may help to determine where is the problem when the test fails on a CI server.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14939#discussion_r1317181285


More information about the compiler-dev mailing list