RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

Adam Sotona asotona at openjdk.org
Thu Sep 7 08:38:51 UTC 2023


On Wed, 6 Sep 2023 19:53:12 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 227 commits:
>> 
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - fixed code printing and ConstantPoolException reporting indoex
>>  - added DydnamicConstantPoolEntry::bootstrapMethodIndex
>>    fix of javap ConstantWriter to print DynamicConstantPoolEntry without accessing BSM attribute
>>  - extended ClassReader about specific entry-reading methods to avoid class cast and throw ConstantPoolException instead
>>  - throwing ConstantPoolException for invalid BSM entry index
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - fixed JavapTask
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - Merge branch 'master' into JDK-8294969-javap
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolException.java
>>  - ... and 217 more: https://git.openjdk.org/jdk/compare/37c756a7...4960751b
>
> src/jdk.jdeps/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java line 134:
> 
>> 132:     private ClassWriter classWriter;
>> 133:     private Map<Integer, List<Note>> pcMap;
>> 134:     private CodeAttribute lr;
> 
> nit: name `lr` doesn't relate much to the type of the field

Right, `lr` historically came from label resolver, I'll fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11411#discussion_r1318277017


More information about the compiler-dev mailing list