RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

[Adam Sotona]

On Thu, 7 Sep 2023 03:10:33 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 227 commits:
>> 
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - fixed code printing and ConstantPoolException reporting indoex
>>  - added DydnamicConstantPoolEntry::bootstrapMethodIndex
>>    fix of javap ConstantWriter to print DynamicConstantPoolEntry without accessing BSM attribute
>>  - extended ClassReader about specific entry-reading methods to avoid class cast and throw ConstantPoolException instead
>>  - throwing ConstantPoolException for invalid BSM entry index
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - fixed JavapTask
>>  - Merge branch 'master' into JDK-8294969-javap
>>  - Merge branch 'master' into JDK-8294969-javap
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolException.java
>>  - ... and 217 more: https://git.openjdk.org/jdk/compare/37c756a7...4960751b
>
> src/java.base/share/classes/jdk/internal/classfile/ClassReader.java line 226:
> 
>> 224: 
>> 225:     /**
>> 226:      * {@return the field ref entry whose index is given at the specified
> 
> I think that `ref` in these APIs should be `reference`

fixed, thanks

> src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java line 465:
> 
>> 463:                 indent(+1);
>> 464:                 print("target_platform: #" + attr.targetPlatform().index());
>> 465: //ToDo find the spec - can be null???
> 
> what about this comment?

removed according to the available spec information

> src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java line 549:
> 
>> 547:             case SourceIDAttribute attr ->
>> 548:                 constantWriter.write(attr.sourceId().index());
>> 549: //            case StackMapAttribute ???
> 
> I guess this comment can be removed

removed, thanks

> src/jdk.jdeps/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java line 46:
> 
>> 44:  *  deletion without notice.</b>
>> 45:  */
>> 46: public class LocalVariableTableWriter extends  InstructionDetailWriter {
> 
> nit: two spaces between `extends` and `InstructionDetailWriter`

fixed, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11411#discussion_r1319670807
PR Review Comment: https://git.openjdk.org/jdk/pull/11411#discussion_r1319669825
PR Review Comment: https://git.openjdk.org/jdk/pull/11411#discussion_r1319669976
PR Review Comment: https://git.openjdk.org/jdk/pull/11411#discussion_r1319671851