RFR: 8194743: Compiler implementation for Statements before super() [v16]

[Archie Cobbs]

On Mon, 25 Sep 2023 17:49:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Have RefBeforeCtorCalledError extend StaticError and customize debug strings.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 245:
> 
>> 243: 
>> 244: # 0: name
>> 245: compiler.err.calls.not.allowed.here=\
> 
> The compiler message key seems overly general. maybe `constructor.call.not.allowed.here` ?

Agreed - will fix.

> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 250:
> 
>> 248: # 0: name
>> 249: compiler.err.return.before.superclass.initialized=\
>> 250:     ''return'' not allowed prior to {0}()
> 
> We have no other match in this file for `prior to`, but we do have matches for `before`. I suggest using the latter for a more consistent style.

Agreed - will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1336299193
PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1336299902