RFR: 8194743: Compiler implementation for Statements before super() [v7]

Archie Cobbs acobbs at openjdk.org
Mon Sep 25 19:35:19 UTC 2023


On Mon, 25 Sep 2023 17:20:04 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Actually, I disagree a bit with the direction here. Having more mutable state is, I believe, not great. In this case the state has to be discarded after a call to `check`, so IMHO having mutable state lying around is a smell. What do you think @vicente-romero-oracle ?
>
> yes @mcimadamore I see your point. And after my comments I think we discussed a similar issue in another bug and we went for the non-mutable state. After revisiting the code I agree that in this case it could be better to avoid having mutable state.

I agree with you both, and will revert this back to creating a new instance each time. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13656#discussion_r1336308671


More information about the compiler-dev mailing list