RFR: 8308753: Class-File API transition to Preview [v2]

Vicente Romero vromero at openjdk.org
Fri Sep 29 23:36:48 UTC 2023

On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Classfile API is an internal library under package `jdk.internal.classfile` in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves it into `java.lang.classfile`.
>> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>> This PR goes in sync with [JDK-8308754](https://bugs.openjdk.org/browse/JDK-8308754): Class-File API (Preview) (CSR)
>> and [JDK-8280389](https://bugs.openjdk.org/browse/JDK-8280389): Class-File API (Preview) (JEP).
>> Online javadoc is available at: 
>> https://cr.openjdk.org/~asotona/JDK-8308753-preview/api/java.base/java/lang/classfile/package-summary.html
>> In addition to the primary transition to preview, this pull request also includes:
>> - All Classfile* classes ranamed to ClassFile* (based on JEP discussion).
>> - A new preview feature, `CLASSFILE_API`, has been added.
>> - Buildsystem tool required a little patch to support annotated modules.
>> - All JDK modules using the Classfile API are newly participating in the preview.
>> - All tests that use the Classfile API now have preview enabled.
>> - A few Javac tests not allowing preview have been partially reverted; their conversion can be re-applied when the Classfile API leaves preview mode.
>> Despite the number of affected files, this pull request is relatively straight-forward. The preview version of the Classfile API is based on the internal version of the library from the JDK master branch, and there are no API features added.
>> Please review this pull request to help the Classfile API turn into a preview.
>> Any comments are welcome.
>> Thanks,
>> Adam
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>   PreviewFeature annotated with JEP 457

make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java line 476:

> 474:                         throw parser.newError("is malformed");
> 475:                     }
> 476:                 } else if (token.equals("import")) {

why is this change necessary?

src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line 34:

> 32: import jdk.internal.javac.PreviewFeature;
> 33: 
> 34: /**

shouldn't we have the preview header applied to all these compilation units?:

{@preview Associated with pattern matching for instanceof, a preview feature of the Java language.


PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1341847954
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1341855569

More information about the compiler-dev mailing list