RFR: JDK-8329717 Missing `@since` tags in elements in DocumentationTool and Taglet

Pavel Rappo prappo at openjdk.org
Fri Apr 5 09:34:11 UTC 2024


On Fri, 5 Apr 2024 00:02:00 GMT, Nizar Benalla <duke at openjdk.org> wrote:

> In this PR I added an `@since` tag to SNIPPET_PATH and isBlockTag() as they were added in later versions
> 
> - SNIPPET_PATH was added in JDK 18 [here](https://github.com/openjdk/jdk/commit/0fc47e99d20a1ee886df878f1302769bdd913aab#diff-8f73114f8b0d0d5229231541d5583382c8e8d33147e285f3d90ed8801ce9228bR192)
> 
> - isBlockTag() was added in JDK 15 [here](https://github.com/openjdk/jdk/commit/3c0e2b4e16d8fb2f96741bc8d4188aa47f58dd15#diff-3ee1b6e2a11b201a39ce3f2ac14ea9832900d8a3a581bf26577064173d0c9082R101)
> 
> This is similar to #18032

Looks good. Thanks.

src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Taglet.java line 99:

> 97:      * @implSpec This implementation returns the inverse
> 98:      * result to {@code isInlineTag}.
> 99:      * @since 15

Might as well insert a blank line above.

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18640#pullrequestreview-1982467362
PR Review Comment: https://git.openjdk.org/jdk/pull/18640#discussion_r1553259747


More information about the compiler-dev mailing list