RFR: JDK-8329717 Missing `@since` tags in elements in DocumentationTool and Taglet [v2]

Pavel Rappo prappo at openjdk.org
Fri Apr 5 12:12:09 UTC 2024


On Fri, 5 Apr 2024 12:01:52 GMT, Nizar Benalla <duke at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/doclet/Taglet.java line 99:
>> 
>>> 97:      * @implSpec This implementation returns the inverse
>>> 98:      * result to {@code isInlineTag}.
>>> 99:      * @since 15
>> 
>> Might as well insert a blank line above.
>
> Done, looking at the existing source code sometimes I find a blank line and sometimes I don't.

Understood; my comment was a mild suggestion, not a requirement. I find it easier to read when `@since` is set off with a blank line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18640#discussion_r1553514019


More information about the compiler-dev mailing list