RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v9]

[Jan Lahoda]

On Mon, 8 Apr 2024 16:36:49 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding tests as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java line 101:
> 
>> 99: import com.sun.tools.javac.tree.JCTree.JCPattern;
>> 100: import com.sun.tools.javac.tree.JCTree.JCPatternCaseLabel;
>> 101: import com.sun.tools.javac.tree.JCTree.JCDerivedInstance;
> 
> changes to this file can be removed now

Thanks, removed:
https://github.com/openjdk/jdk/pull/18509/commits/a05480cd1a436014ba00505db71d54d82a37ecd1

> test/langtools/tools/javac/patterns/withers/Model.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> probably this test should be in another location not under `patterns`, same for other tests added inside `patterns` folder

Thanks, moved:
https://github.com/openjdk/jdk/pull/18509/commits/a05480cd1a436014ba00505db71d54d82a37ecd1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1557304771
PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1557304921