RFR: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util

Jan Lahoda jlahoda at openjdk.org
Wed Apr 17 14:18:00 UTC 2024


On Wed, 17 Apr 2024 11:13:03 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> I have a few inline comments and a dumb question. The question: what happens if a preview feature exits the preview stage without being promoted to the standard, i.e. the preview feature is dropped?

When the preview feature is dropped, I would assume the API elements related to it would be removed. The `Preview` help with that, as they stay, only the methods are removed. At least, this is what I would expect.

Overall, looks reasonable to me. I wonder if the text should say the newly-added API entry points should be marked as preview? I assume it may be difficult to talk explicitly about `@jdk.internal.javac.PreviewFeature` here, but maybe a general note that it should be ensured the entry points are recognized as preview? Or did I miss that? Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18804#issuecomment-2061367197


More information about the compiler-dev mailing list