RFR: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util [v7]

[Pavel Rappo]

On Fri, 19 Apr 2024 00:30:16 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Provide more concrete discussion of how the preview visitors are expected to evolve for different categories of language changes.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Respond to review feedback.

Looks good; thanks.

src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 44:

> 42:  * As the Java programming language evolves, the visitor interfaces of
> 43:  * the language model also evolve as do the concrete visitors in this
> 44:  * package. A preview language feature in JDK <i>N</i> may have API

Consider adding this or similar unobtrusive link:

Suggestion:

 * package. A <a href="https://openjdk.org/jeps/12">preview language feature</a> in JDK <i>N</i> may have API

src/java.compiler/share/classes/javax/lang/model/util/package-info.java line 229:

> 227:  *                LOCAL_VARIABLE, EXCEPTION_PARAMETER, RESOURCE_VARIABLE,
> 228:  *  -             BINDING_VARIABLE -> true;
> 229:  *  +            BINDING_VARIABLE, PREVIEW_FEATURE_2 -> true;

Nit:
Suggestion:

 *  +             BINDING_VARIABLE, PREVIEW_FEATURE_2 -> true;

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18804#pullrequestreview-2010962237
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1572095363
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1572198106