RFR: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util [v8]

Jonathan Gibbons jjg at openjdk.org
Fri Apr 19 19:04:04 UTC 2024


On Fri, 19 Apr 2024 18:54:32 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Provide more concrete discussion of how the preview visitors are expected to evolve for different categories of language changes.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement review feedback; add link in remainder of preview visitor classes.

Marked as reviewed by jjg (Reviewer).

src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitorPreview.java line 43:

> 41:  * @param <P> the type of the additional parameter to this visitor's methods.
> 42:  *
> 43: * @see <a href="package-summary.html#expectedEvolution">

FWIW, I would expect that you could write this as


@see package-name##id   description

-------------

PR Review: https://git.openjdk.org/jdk/pull/18804#pullrequestreview-2012155914
PR Review Comment: https://git.openjdk.org/jdk/pull/18804#discussion_r1572794286


More information about the compiler-dev mailing list