RFR: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp [v2]
Jonathan Gibbons
jjg at openjdk.org
Wed Apr 24 18:42:41 UTC 2024
On Wed, 24 Apr 2024 18:40:15 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change that now uses a source generator and compiler task to verify no SOE is thrown.
>>
>> This change replaces over 1000 lines of code that were being compiled by running this test as well as other tests crawling over test files. Some of those crawling tests failed to parse this formerly large file. The new size of this test file should be no problem for them.
>>
>> The level of nesting is increased from 567 to 1000.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Introduce constant for the depth of nesting levels
Approved, with a minor suggestion
-------------
Marked as reviewed by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18939#pullrequestreview-2020650233
More information about the compiler-dev
mailing list