RFR: 8309881: Qualified name of a type element depends on its origin (source vs class) [v2]

Jan Lahoda jlahoda at openjdk.org
Fri Apr 26 08:25:34 UTC 2024


On Wed, 24 Apr 2024 06:19:44 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> `javax.lang.model.type.TypeMirror::toString` says: "Any names embedded in the result are qualified if possible."
>> However in reality the form of the names depends on the source vs.class origin.
>> 
>> This patch enforces qualified name to be used.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Suggested test revealed the fix is not sufficient
>   
>   Co-authored-by: jlahoda

Looks good to me. Thanks!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18917#pullrequestreview-2024417464


More information about the compiler-dev mailing list