RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

Chen Liang liach at openjdk.org
Fri Aug 2 00:43:46 UTC 2024


1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
2. Improved value specification to specify their tags.
3. Improved value factories to return their specific types instead of `OfConstant`
4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`

-------------

Commit messages:
 - 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

Changes: https://git.openjdk.org/jdk/pull/20436/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20436&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335927
  Stats: 273 lines in 11 files changed: 106 ins; 34 del; 133 mod
  Patch: https://git.openjdk.org/jdk/pull/20436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20436/head:pull/20436

PR: https://git.openjdk.org/jdk/pull/20436


More information about the compiler-dev mailing list