RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations [v2]

Liam Miller-Cushon cushon at openjdk.org
Mon Aug 12 18:15:55 UTC 2024


On Fri, 9 Aug 2024 19:26:04 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> right I guess I was confused by the key in the error message: `type.annotation.not.found`
>
> Good point, I will think of a better name for the diagnostic key.
> 
> It would also work to use a more generic error message for this, but I think it is helpful to include some context about the annotation that was being attached when the completion failure occurred, as a hint to where the problem is.

I reworked the diagnostic a bit and updated the key to `compiler.err.cant.attach.type.annotations`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20495#discussion_r1714194703


More information about the compiler-dev mailing list