RFR: 8337998: CompletionFailure in getEnclosingType attaching type annotations [v2]

Tue Aug 13 01:01:09 UTC 2024

On Mon, 12 Aug 2024 21:13:01 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8337998
>>  - Update diagnostic key and text to refer to 'attaching', not 'reading' type annotations
>>  - Update diagnostic key
>>  - Update not-yet list
>>  - Remove unused import
>>  - 8337998: CompletionFailure in getEnclosingType attaching type annotations
>
> test/langtools/tools/javac/annotations/typeAnnotations/CompletionErrorOnEnclosingType.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8332850
>> 27:  * @summary XXX
> 
> looks good, nit: we will need a meaningful summary here

Thanks, fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20495#discussion_r1714521909