Integrated: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

Chen Liang liach at openjdk.org
Tue Aug 13 15:17:04 UTC 2024


On Fri, 2 Aug 2024 00:39:12 GMT, Chen Liang <liach at openjdk.org> wrote:

> 1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`)
> 2. Improved value specification to specify their tags.
> 3. Improved value factories to return their specific types instead of `OfConstant`
> 4. Improved value classes to return specific `PoolEntry` subtypes and specific live constant subtypes
> 5. Removed confusing and meaningless `ConstantPoolBuilder.annotationConstantValueEntry`

This pull request has now been integrated.

Changeset: 6af1d6ff
Author:    Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6af1d6ff210b3ddbc7d1585428b49631248a500b
Stats:     397 lines in 12 files changed: 216 ins; 39 del; 142 mod

8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

Reviewed-by: asotona

-------------

PR: https://git.openjdk.org/jdk/pull/20436


More information about the compiler-dev mailing list