RFR: 8337851: Some tests have name which confuse jtreg [v2]

toshiogata duke at openjdk.org
Fri Aug 16 01:05:22 UTC 2024


On Wed, 14 Aug 2024 23:43:14 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> toshiogata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move jtreg tags and expand wildcard imports
>
> test/langtools/tools/javac/generics/parametricException/ParametricException.java line 1:
> 
>> 1: /*
> 
> since you're renaming this file for jtreg testing anyway could you move the jtreg tags down below the imports and expand the wildcard import?

As you mentioned, it's a good time to make a minor improvement, so I modified the test.

> test/langtools/tools/javac/warnings/Serial/Serial.java line 1:
> 
>> 1: /*
> 
> move jtreg tags below imports and add copyrights

The copyright has been intentionally omitted as explained in https://bugs.openjdk.org/browse/JDK-8258525
I moved the jtreg tag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1719166472
PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1719166674


More information about the compiler-dev mailing list