RFR: 8337851: Some tests have name which confuse jtreg [v3]

Jonathan Gibbons jjg at openjdk.org
Fri Aug 23 22:39:03 UTC 2024


On Fri, 23 Aug 2024 22:31:04 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> toshiogata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Move jtreg tags and expand wildcard imports"
>>   
>>   This reverts commit 9b30df1230b7e31b42e63ae01ef1549565bcc078.
>
> Moving files from one directory to another can sometimes be a bit risky, especially for `javac` tests, because that implies moving the classes from one unnamed package to a different unnamed package.
> 
> Please confirm that all tests under `test/langtools/tools/javac` continue to pass after the files have been moved. You can either run just those tests, or run all langtools `tier1` tests if that is easier.

> > @jonathan-gibbons Is this a bug in jtreg, or where these files actually improperly named?
> 
> Not a bug as such, but maybe a little-known misfeature. `jtreg` has always had problems with filenames that could cause confusion, and the general sense has generally been, "if it hurts, don't do it!". That being said, our overall library API and infrastructure is way better these days than in times past, and it might be reasonable to file an Enhancement for `jtreg` to have a utility/check/test to detect these anomalous situations.
> 
> In the meantime, renaming the files to avoid the problem is the recommended solution.

Filed https://bugs.openjdk.org/browse/CODETOOLS-7903803

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20475#issuecomment-2307890897


More information about the compiler-dev mailing list