RFR: 8344079: Minor fixes and cleanups to compiler lint-related code [v4]

[Maurizio Cimadamore]

On Sat, 30 Nov 2024 17:35:56 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review these changes with some minor lint-related fixes and cleanups.
>> 
>> See [JDK-8344079](https://bugs.openjdk.org/browse/JDK-8344079) for a more detailed description.
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment by being less Streamy.

src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java line 717:

> 715:                                                   processor, log, lint));
> 716:                     if (lint && !patternAdded) {
> 717:                         log.warning(PROCESSING, null, Warnings.ProcDuplicateSupportedAnnotation(annotationPattern,

Did you run all langtools tests? I believe that if you change these, some test output will be broken, as an extra `[processing]` will be emitted. I'm seeing this while playing in a related area.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22056#discussion_r1865867119