RFR: 8344079: Minor fixes and cleanups to compiler lint-related code [v4]

[Maurizio Cimadamore]

On Mon, 2 Dec 2024 14:17:52 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Example: test/langtools/tools/doclint/AnonClassTest.java
>
>> Did you run all langtools tests? 
> 
> I did not run any tests beyond those that are run by GA - but they are all passing.
> 
>> Example: test/langtools/tools/doclint/AnonClassTest.java
> 
> When I run that test manually it passes... are you seeing it fail?
> 
> 
> $ make test TEST="test/langtools/tools/doclint/AnonClassTest.java"
> Building target 'test' in configuration 'macosx-aarch64-server-release'
> Test selection 'test/langtools/tools/doclint/AnonClassTest.java', will run:
> * jtreg:test/langtools/tools/doclint/AnonClassTest.java
> 
> Running test 'jtreg:test/langtools/tools/doclint/AnonClassTest.java'
> Passed: tools/doclint/AnonClassTest.java
> Test results: passed: 1
> Report written to /Users/archie/proj/jdk/build/macosx-aarch64-server-release/test-results/jtreg_test_langtools_tools_doclint_AnonClassTest_java/html/report.html
> Results written to /Users/archie/proj/jdk/build/macosx-aarch64-server-release/test-support/jtreg_test_langtools_tools_doclint_AnonClassTest_java
> Finished running test 'jtreg:test/langtools/tools/doclint/AnonClassTest.java'
> Test report is stored in build/macosx-aarch64-server-release/test-results/jtreg_test_langtools_tools_doclint_AnonClassTest_java
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR   
>    jtreg:test/langtools/tools/doclint/AnonClassTest.java
>                                                          1     1     0     0   
> ==============================
> TEST SUCCESS
> 
> Finished building target 'test' in configuration 'macosx-aarch64-server-release'

That seems ok. So probably there's something else broken in my repository. Tests do seem green with this PR, so that seems to point at a local issue on my part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22056#discussion_r1865962944