RFR: 8345248: Module name 'transitive' not accepted for `requires transitive` [v2]

Vicente Romero vromero at openjdk.org
Tue Dec 3 14:56:41 UTC 2024


On Fri, 29 Nov 2024 14:30:57 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Considering module named `transitive`, it should be possible to write: `requires transitive;`, which works, and also `requires transitive transitive;`, which currently does not work:
>> 
>> $ javac -d out/ --module-source-path . transitive/module-info.java test/module-info.java
>> test/module-info.java:2: error: repeated modifier
>>     requires transitive transitive;
>>                         ^
>> test/module-info.java:2: error: <identifier> expected
>>     requires transitive transitive;
>>                                   ^
>> 2 errors
>> 
>> 
>> The proposed solution is to properly handle lookahead if the transitive flag has already been seen.
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing test.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22460#pullrequestreview-2475941695


More information about the compiler-dev mailing list