RFR: 8345319: Fix the tag type in PoolEntry and AnnotationValue [v2]
Adam Sotona
asotona at openjdk.org
Tue Dec 3 16:05:44 UTC 2024
On Mon, 2 Dec 2024 18:06:53 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Change the return type of PoolEntry and AnnotationValue tags to int, as in TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact is that AnnotationValue tags should be converted to char before printing now.
>>
>> Please review the associated CSR for this hotfix as well.
>>
>> Testing: classfile and javap, tier 1-3 in progress
>>
>> Pinging @lukellmann
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix AnnotationDefaultTest
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22489#pullrequestreview-2476137338
More information about the compiler-dev
mailing list