RFR: 8345474: Translation for instanceof is not triggered when patterns are not used in the compilation unit [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Dec 4 11:01:55 UTC 2024


On Wed, 4 Dec 2024 10:59:00 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> Our tests for #21539 covered the case of using `instanceof` as both a type comparison operator and a pattern matching operator in a single compilation unit. That concealed the fact that the translation is getting triggered only when the compilation unit `hasPatterns`. This was evident/reproducible also by experimentation using jshell. This PR addresses this issue.
>
> Aggelos Biboudis has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8345474: Translation for instanceof is not triggered when patterns are not used in the compilation unit

Good catch!

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22541#pullrequestreview-2478135992


More information about the compiler-dev mailing list