RFR: 8334714: Implement JEP 484: Class-File API [v9]

[ExE Boss]

On Fri, 15 Nov 2024 14:35:26 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/classfile/CustomAttribute.java
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/classfile/AccessFlags.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassBuilder.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassElement.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassFileTransform.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassHierarchyResolver.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassModel.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassReader.java
>>    #	src/java.base/share/classes/java/lang/classfile/ClassSignature.java
>>    #	src/java.base/share/classes/java/lang/classfile/CodeBuilder.java
>>    #	src/java.base/share/classes/java/lang/classfile/CodeElement.java
>>    #	src/java.base/share/classes/java/lang/classfile/CodeModel.java
>>    #	src/java.base/share/classes/java/lang/classfile/CompoundElement.java
>>    #	src/java.base/share/classes/java/lang/classfile/FieldBuilder.java
>>    #	src/java.base/share/classes/java/lang/classfile/FieldElement.java
>>    #	src/java.base/share/classes/java/lang/classfile/Instruction.java
>>    #	src/java.base/share/classes/java/lang/classfile/MethodBuilder.java
>>    #	src/java.base/share/classes/java/lang/classfile/MethodElement.java
>>    #	src/java.base/share/classes/java/lang/classfile/TypeKind.java
>>    #	src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTableAttribute.java
>>    #	src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTypeTableAttribute.java
>>    #	src/java.base/share/classes/java/lang/classfile/attribute/RuntimeInvisibleAnnotationsAttribute.java
>>    #	src/java.base/share/classes/java/lang/classfile/attribute/RuntimeVisibleAnnotationsAttribute.java
>>    #	src/java.base/share/classes/java/lang/classfile/constantpool/AnnotationConstantValueEntry.java
>>    #...
>
> Thank you!

@asotona
> > I wish that the concrete `PoolEntry` subtypes had `of(…)` factory methods...
> 
> Please forward the proposal on clasfile-api-dev mailing list, where it can be discussed. Thank you.

I filed [JDK‑8345737] for that, and would prefer that at least `jdk.internal.classfile.impl.TemporaryConstantPool` were fully implemented in **JDK 24** (see [JDK‑8345734]).

[JDK‑8345734]: https://bugs.openjdk.org/browse/JDK-8345734
[JDK‑8345737]: https://bugs.openjdk.org/browse/JDK-8345737

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19826#issuecomment-2528944663